Re : [MPlayer-dev-eng][PATCH]-vofile option (ENGLISH)

[Olivier Rolland]

On 11/16/04 23:33:17, Reimar Döffinger wrote:

> I think it would be better to add a driver suboption instead of yet
> another option that works for only one driver...

Well, inspiration was taken from -aofile: one option, one driver.

> But you will have to rework the current suboption parsing (in preinit
> function, line 480).
> You might want to have a look at CVS versions of vo_gl.c, line 551  
> and ao_alsa, line 348, those parsing routines have been redone lately  
> and should work better then some others you might find...

I'll took a look on that.

> I'm not sure what the documentation guys think, but I'd prefer it if
> you'd leave the translations to them. First of all because it makes
> the patch harder to read because I have skip lots of (to me)  
> irrelevant parts and also the synced-with tags for the translations  
> would have to be adjusted when applying...

I just followed the hints in patches.txt:

"Updating the English documentation is enough. If you speak several  
languages you are of course welcome to update some of the translations  
as well."

Even though I don't speak all the languages I have translated for, it  
was easy enough to do it with just a few cut'n pastes...

Anyway, following your suggestion, I removed all the translations other  
than english.

> > +	if(!vo_outputfilename) {
> > +		vo_outputfilename = strdup("stream.yuv");
> > +	}
> 
> I don't think assigning to configuration variables isn't such a good
> idea, they are global variables and you never can know what is done
> with
> them (e.g. whether they are freed or not).
> 
> > +	yuv_out = fopen(vo_outputfilename, "wb");
> 
> I'd suggest (vo_outputfilename) ? vo_outputfilename : "stream.yuv".  
> Or use a temporary variable, if you dislike the ?: operator ;-)

Done, a new version is attached.

Greetings,

Olivier Rolland
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-vofile.patch
Type: text/x-patch
Size: 4307 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041117/11911b0a/attachment.bin>