[MPlayer-dev-eng] [PATCH] reduce verbosity in some places

Diego Biurrun diego at biurrun.de
Sat Nov 13 18:05:05 CET 2004


Reimar Döffinger writes:
> 
> On Mon, Nov 08, 2004 at 01:37:23AM +0100, Diego Biurrun wrote:
> > Reimar Döffinger writes:
> > >  
> > > Instead of removing the newlines at the beginning I'd actually prefer to
> > > have some for -ac help -vc help etc...
> > > For those the output looks like this, it all hangs together far to much
> > > for my taste...
> > > 
> > > > Reading config file /etc/mplayer/mplayer.conf
> > > > Reading config file /home/reimar/.mplayer/config
> > > > Reading /home/reimar/.mplayer/codecs.conf: 77 audio & 181 video codecs
> > > > Available video codecs:
> > > > vc:         vfm:      status:   info:  [lib/dll]
> > > > mpegpes     mpegpes   working   Mpeg PES output (.mpg or Dxr3/DVB card)
> > > > mpeg12      libmpeg2  working   MPEG 1 or 2 (libmpeg2)
> > 
> > Just look what my local tree prints:
> > 
> > silver:/usr/src/mplayer/dev$ ./mplayer -ac help
> > MPlayer dev-CVS-041009-21:35-3.3.4 (C) 2000-2004 MPlayer Team
> > 
> > Available audio codecs:
> > ac:         afm:      status:   info:  [lib/dll]
> > wma9dmo     dmo       working   Windows Media Audio 9 DMO  [wma9dmod.dll]
> > wmadmo      dmo       working   Windows Media Audio DMO  [wmadmod.dll]
> > 
> > :-)
> 
> Well, but it just works by chance I think... If there should be a
> newline before the "Available audio codecs" then the \n should also be
> in the beginning of that string... Less risk of breaking when changing
> things.
> Also, this is almost a bit too much stripped down for my taste.
> Anyway, documentation is in your responsibility and I consider that
> documentation ;-)

Well, what else do you want?  It prints version information and the
requested info...

Here comes another version of my patch, it should now only change the
simple stuff, the rest can be discussed and applied later on.

Speak up or I will apply around Monday ;-)

Diego




More information about the MPlayer-dev-eng mailing list