[MPlayer-dev-eng] Re: [PATCH] -identify vids, aids, sids, alangs and slangs

[kiriuja]

> > The only easy way to fix this mess I could think of was to change the
> > accepted aids and vids to match the internal ones,
> 
> Or fix the demuxers to all use zero-based IDs (which would be MUCH more
> consistent than the mess we have now...).

Note that I said _easy_ way. :-)

> > but I understand you (and Richard) object to that,
> 
> Strongly. It's a matter of usability (which mplayer lacks in too many
> ways already). Having to call mplayer once just to find out the correct
> IDs to use for the first audio track or so is simply not acceptable.

Well, yeah, except now you have to do it anyway, unless you happen to
know what demuxer is going to be used _and_ remember what numbering
scheme that particular demuxer uses.

And by the way, if you do run it (with -v), demux_ogg and demux_mkv
will report wrong values. Do you think we should at least turn that
output off based on that same demux_aid_vid_mismatch flag?

> > So the demux_aid_vid_mismatch is the workaround that tells new_sh_*
> > not to print the ids it gets, in which case it is the demux module
> > that prints them.
> 
> In fact this could be changed. For demux_ogg.c you've already introduced
> a new member "id" which stores the -Xid ID. How about you extend the
> patch so that demux_ogg.c always uses those? :)

I'm not sure my knowledge of demux_ogg.c is sufficient for that.
Plus, I would really prefer that to be a separate patch.

> > The patch will be one line shorter, but the resulting code one line
> > longer. Whatever your preference. :-)
> 
> Shorter patches. Makes reviewing easier.

You got it. Updated patch attached, with all discussed changes.
Tested and works here.

> > Another minor problem in demux_ogg is that demux_ogg_check_comments
> > only gets called for streams that are actually going to be used, and
> > so the other stream languages are not known until they are actually
> > played. But I am guessing there is not easy fix for that.
> 
> Well, the "best" way IMHO would be to have demux_ogg_open parse ALL
> header packets of ALL streams before returning. That way we could also
> enable -alang.

That would be great.

> > Thanks for looking at the patch.
> 
> You're welcome. I'm sorry I cannot really comment on the other
> parts. demux_ogg.c and demux_mkv.c are the ones I know best, so I
> preferred to talk only about those.

OK, so anyone with a clue about vobsub/dvdsub stuff would like to have
a look? It's quite straightforward actually.

--
kiriuja
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-identify-1-1.patch
Type: text/x-diff
Size: 13531 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041109/1004c400/attachment.patch>