[MPlayer-dev-eng] [REQ FOR COMMENT] HRTF headphone libaf filter

Ivan Kalvachev ivan at cacad.com
Tue Nov 9 01:09:29 CET 2004


On Tue, 2 Nov 2004 16:20:29 -0500
D Richard Felker III <dalias at aerifal.cx> wrote:

> On Tue, Nov 02, 2004 at 10:20:54AM +0100, Reimar D_ffinger wrote:
> > Hi,
> > 
> > don't use exit, abort or any such functions, they can leave the console 
> > in an unusable state. exit_player is the right function to use.
> 
> in fact, looking at the code, all of these malloc checks should be
> removed. there's no reason for them to be there...they just clutter
> the code.


Rich, never give such crappy advices. Also never presume that this code will work
on horribly mind-broken happy memory malloc implementation like Linux one.

Checking of return argument is mandatory. That is doesn't happen for you is not excuse.
Neither is excuse that such code is used on many places.

Take Care
   Ivan Kalvachev
  iive




More information about the MPlayer-dev-eng mailing list