[MPlayer-dev-eng] [PATCH] Mac OS X Finder support

[Reimar Döffinger]

Hi,
> >Two things here:
> >Use test instead of [], that's how it's done everywhere else, lets
> >better not risk portability issues.
> >If --enable or --disable are given always behave like
> >that even if it seems sense less (there are enough configure parts that
> >violate that rule).
> 
> Applied the suggestion. This allows --enable-macosx-finder-support even 
> if macosx is not defined, causing the build of mplayer to fail at link 
> stage with a missing _main() -- is this a good thing?

Not good, but it's what the user wanted. Whoever feels knowing enough to
not just rely on autodetection gets whatever he/she/it deserves.

> >The fprintfs in macosx_main seem to be for debugging. They should be
> >commented-out, removed or whatever.
> 
> Some of the fprintfs are error messages, I've changed them with 
> mp_msg(), the others where removed.

Umm... are you sure that's a good idea? I think that funtion runs before
mp_msg is initialized... Please double-check. If those are really
(fatal) errors, output to stderr is okay I think.

Greetings,
Reimar Döffinger