[MPlayer-dev-eng] [PATCH] Mac OS X Finder support

[Chris Roccati]

On 6 Nov 2004, at 18:23, Reimar Döffinger wrote:
> Two things here:
> Use test instead of [], that's how it's done everywhere else, lets
> better not risk portability issues.
> If --enable or --disable are given always behave like
> that even if it seems sense less (there are enough configure parts that
> violate that rule).

Applied the suggestion. This allows --enable-macosx-finder-support even 
if macosx is not defined, causing the build of mplayer to fail at link 
stage with a missing _main() -- is this a good thing?

> The fprintfs in macosx_main seem to be for debugging. They should be
> commented-out, removed or whatever.

Some of the fprintfs are error messages, I've changed them with 
mp_msg(), the others where removed.

> The patch to version.h needs explanation. But as it is unrelated
> it must be in an independent patch anyway...

I will send it in a separate patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: macosx_finder.patch
Type: application/octet-stream
Size: 5957 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041106/00ecb465/attachment.obj>