[MPlayer-dev-eng] [PATCH] configure: deal with newer head's and tail's dislike of -1

Diego Biurrun diego at biurrun.de
Sat Nov 6 21:48:43 CET 2004


D Richard Felker III writes:
> On Sat, Nov 06, 2004 at 10:12:25AM +0200, Jan Knutar wrote:
> > On Saturday 06 November 2004 10:57, Sascha Sommer wrote:
> > 
> > > If it gets reversed please take care of the polypaudio configure checks, I 
> > > added afterwards.
> > 
> > If code added afterwards, then it can't be reversed. I remember the whole
> > x11_common.c fiasco that left it broken for ages.
> 
> it can be reversed...i just did it. the patches are orthogonal so it's
> no problem.

It is a problem, a BIG one.  Also you are repeating past mistakes,
there was an infamous flame between myself and Gabu after he misused
'cvs admin -o' on libvo/x11_common.c.  So read through section I
paragraph 9 of DOCS/tech/cvs-howto.txt and memorize it:


  9. Reverting broken commits

    In case you committed something really broken and wish to undo it
    completely, you can use the 'cvs admin -o' command, which removes
    entries from the revision history of a file. It does not undo the
    changes related to that revision, but for the corner case that you
    remove the last revision (and only then!) this amounts to
    reverting a commit.

    Assuming that 1.123 is the last revision

      cvs -z3 admin -o1.123 filename

    will remove revision 1.123, thus reverting the file back to
    revision 1.122.

    ONLY use this command to delete the LAST revision of a
    file. Removing other revisions will NOT undo the changes connected
    to that revision, so the last revision will remain unmodified,
    only revision history will be lost and holes left in the revision
    numbering.


Even now that you "reversed" the latest revision of configure the
situation is not really fixed.  The commit has the wrong date, author
and commit message.  Thus it gets harder to correlate it to what was
sent to -cvslog.

Now where were those Cola pictures going around lately?  Have a good
look and feel inspired...

Diego




More information about the MPlayer-dev-eng mailing list