[MPlayer-dev-eng] [PATCH] forceable software volume control

[The Wanderer]

(I sent an earlier post about this, which hasn't been delivered and has
produced an error message, and now that I look at that post again it
makes no sense. If by some chance that earlier reply makes it through,
please ignore it.)


Reimar Döffinger wrote:

> Hi,
> 
>>> In principle MPlayers 0% - 100% range of volume is mapped to a 0%
>>> - 100/softvol-norm% range for the real volume change.
>> 
>> Useful to have that stated explicitly, at least in my current state
>> of mental competence. Would it be "getting into too much detail" to
>> mention that little 'equation' in the man page? I gathered
>> something vaguely along those lines from the form in the patch you
>> have, but the specifics can be nice to know.
> 
> Actually, I'd like to propose the attached patch instead. I think
> this is easier to understand...

Yes, this is much nicer - and, having finally gotten it to apply, it
does appear to work for me. In practice as in theory, I don't like the
default maximum being only a little above the unmodified value, but that
can be adjusted in the config file.

In relation to that debate about the default, I'd note that I can set
soft-vol-max as high as 700 and go all the way up to that maximum
without noticeable artifacting... I'm reluctant to experiment much
higher than that, because it begins to get uncomfortably loud. Still,
that's certainly much higher than the ceiling for which you provided
that justification. (I'm not going to push too hard on this point, but I
do also prefer to not leave things unfinished.)

As a bit of a side note, if you're aiming to approximate the 90% value
as your default, 111 would be closer than 110.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.