[MPlayer-dev-eng] [PATCH] Mac OS X Finder support

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Nov 5 22:36:44 CET 2004


Hi,

> >This patch allows mplayer to be launched from the finder, to be used 
> >as default application for a filetype and to be used as a drop target 
> >if placed on the dock. The compiled mplayer binary must be either 
> >packaged in an appwrapper directory, with an appropriate Info.plist 
> >describing the supported filetypes or a suitable resource fork must be 
> >grafted to the binary -- both methods, as a side effect, will remove 
> >the need for the "foreground operation" workaround in vo_quartz.c in 
> >function preinit. The first way is the one currently recomended by 
> >apple, whereas the second is somewhat "cleaner" in the current 
> >building environment. At the moment the patch does NEITHER.
> 
> Anyone care to comment on this patch? Can it be commited?

Ok, just a quick reply...
Well, it adds a big hunk of code to mplayer.c - I don't really like
that, especially as it's system specific. Could it be put in a seperate
file (maybe in osdep??), best even with possibility to disable?
Also I think there are already quite a few escaping/unescaping functions in MPlayer, maybe it's not necessary to add another one, but I don't know...

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list