[MPlayer-dev-eng] [PATCH] forceable software volume control

[Torinthiel]

On Thu, Nov 04, 2004 at 08:20:57PM -0500, The Wanderer wrote:
> 
> Reimar Döffinger wrote:
> 
> >Hi, this patch allows to force the volume to be changed via af_volume
> >instead of hardware mixer. This should remove the last reason for
> >keeping aop (and I _really_ want that outdated crap out of CVS).
> 
> For one thing, this doesn't apply for me (to latest CVS). I don't know
> why - the patch doesn't look malformed - but 'patch -p0 <
> ../soft_vol_ctrl.diff' gives seven "Hunk # of # FAILED in <filename"
> messages over four different files.

Works for me. At least patch --dry-run.

> >+.B \-softvol-norm <10.0\-200.0>
> >+Set volume bar position at which volume will not be changed (in percent)
> >+(default: 90).
> 
> I don't think it's good to have the default "unchanged" volume be near
> the maximum possible. Unless some solid justification for a higher value
> can be provided, I would prefer to have this default to 50.

Have you read it? Or have you read the code and here is wrong?
I see the range is 50-200. How is 90 close to 200? If you want it neat
the middle of scale, which I find reasonable, then 90 is better then 50,
and 100 would be even better. Or the code accepts 50-100, and 200 in
manpage patch is a mistake.
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)megapolis(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20041105/92d576f6/attachment.pgp>