[MPlayer-dev-eng] [PATCH] EDL cleanup and fixes

[Oded Shimon]

On Wednesday 03 November 2004 13:00, Reimar Döffinger wrote:
> Hi,
>
> > > Small EDL cosmetic patch that previously would break code folding
> > > programs.
> >
> > Rejected. This will break with gcc 2.95
>
> Hmm, actually it does not... Though I still don't like this patch.
>
There is more than the cosmetic reason why I applied this patch, as it is now 
is:
#ifdef edl
     if (var) {
#else
     if (1) {
#endif
           ...
           ...
    }


my patch turns it into:
#ifdef edl
     if (var) {
#endif
           ...
           ...
#ifdef edl
    }
#endif




Which is exactly how this thing is done almost everywhere else in MPlayer 
code, except here. I also find this method a little clearer.
in a later patch, i want to also change it to this:
#ifdef edl
     if (var) {
#endif
           ...
           ...
#ifdef edl
           var = 0;
    }
#endif



So its more than just a cosmetic patch. its a cosmetic patch now, to turn itno 
a functionability patch later.

Personal note to Reimar - Reynaldo said he's willing to submit the patch if 
you say it's OK. So please reply (if you don't find it OK, please at least 
reply a rejection).

- ods15