[MPlayer-dev-eng] [PATCH] EDL cleanup and fixes

[Oded Shimon]

On Wednesday 03 November 2004 19:25, Reimar Döffinger wrote:
> Hi,
> I know Reynaldo said so, but what good should using a counter be? It
> seems to me that this only complicates code.
Well, that was his decision, I'm not gonna argue...
I believe that its better the other way, but he asked this.

> > +#ifdef USE_EDL
> > +      user_muted = user_muted ? 0 : 1;
>
> user_muted = !user_muted;
> seems much clearer to me...
I agree, it is clearer, and i personally love that little trick. :)
but it doesn't work here, I need to work with either 1 or 0, not -1 or 0, 
because it is compared mixer.muted, which i didn't invent, and it uses 1 or 
0.
I could use
user_muted = !user_muted & 1;

If you prefer... :)
Reynaldo is in the middle of applying the patch right now anyway, so no point 
in changing it now.

- ods15