[MPlayer-dev-eng] [PATCH] EDL cleanup and fixes

[Oded Shimon]

On Wednesday 03 November 2004 16:37, Reynaldo H. Verdejo Pinochet wrote:
> As long as im trying to give your work the attention it deserves. this
> kind of futile changes dont make it any easier for me, please take the
> time to review your patches so they do not change anything without
> a real purpose, if i found another thing like this on it. i'll just
> throw it away.
I'm sorry if I am giving you a hard time, I don't mean to.

I am only trying to help, and apparently I keep doing it in a bad way, the 
problem is you guys are not telling me what I am doing wrong. You just keep 
rejecting my patches saying "this is wrong" and nothing else...

The way edl_mute was written before was broken for certain scenarios, I have 
tested it myself, and it failed for some cases. When I looked at the code, I 
found it to be written with a lot of unnecessary code. If what you really 
prefer is that I leave this code and just fix it to work for the broken 
scenarios it does earlier, I can do that, but I personally believe that it is 
a waste, which is why I made a patch that removes the unnecessary code and 
uses a new, slightly faster and less code method.

If this is what is wrong, please, just TELL me, because all you rejections to 
my patches have been to me very un-understandable.
If it was something else that I did wrong then tell me what it is... I'll fix 
whatever you ask me to, I just don't understand what you want me to fix.

I am not trying to be a burden on you. :(  I am only trying to help, and I 
don't understand what i am doing wrong.

- ods15