[MPlayer-dev-eng] [PATCH] realvideo/audio support in mac osx.

[Nicolas Plourde]

Reimar � wrote:

>Hi,
>  
>
>>>>>Following my previous e-mail here is the patch I propose.
>>>>>If there is no objection i will commit this asap before pre6 release.
>>>>>
>>>>>          
>>>>>
>>>>commited
>>>>        
>>>>
>>>You really should give more than one day to review, we all are busy! I 
>>>can't see how it makes sense to remove code when there already is a #ifdef
>>>around it! And as I said already another time, removing features is 
>>>against rule number 4 in cvs-howto! please stick to those rules!
>>>
>>>      
>>>
>>This was default at enable and broken. When code is poorly coded in the 
>>first place and dont even work its should be removed IMHO.
>>    
>>
>
>No, it should never have been applied. If it's broken and in CVS it should be disabled or even better, fixed IMHO. This quite a bit of code and I'm
>sure somebody has spend quite some time on coding it - removing it is hardly nice. I also think that it is impossible to say if not somebody
>actually got it to work, fixed it or whatever...
>
>  
>
>>The result of this patch get you working real video vs. crash, I suppose 
>>I did had a feature after all.
>>    
>>
>
>My point was that this could have been achieved by undefining that USE_...
>
>  
>
>>I know everyone is busy but please try to trust other dev with there work.
>>    
>>
>
>I was just stating my opinion, which I think is backed by CVS rules. It would be really nice if other developers would speak up too, I don't want
>to end up being the "bad guy", but I certainly _am_ uncomfortable with that commit.
>
>Greetings,
>Reimar Döffinger
>
>  
>

Dont worry you are not the bad guy, I just want to make it clear this 
code was not fixable. the codec (shlb) relying on this where broken. I 
cant fix the codec, can I?
thats why i removed the old code. I saw this code has uneeded and 
missleading thats all. And has a mac osx user and knowing other user opinion
on this old codec support i can assure you that this never worked, 
atleast without any obscure information the original author is the only 
one to know
since its not in the doc.

Why are you uncomfortable with this commit beside the rule, anything 
else causing problem, bug or break something?

I think rule 4 should be revised btw. but that is another story.

-- 
====
Nicolas Plourde <nicolas.plourde at sympatico.ca>