[MPlayer-dev-eng] [PATCH] ve_xvid4.c: have each option flag have its counterpart

Guillaume POIRIER guillaume.poirier at etudiant.univ-rennes1.fr
Tue Nov 2 18:24:03 CET 2004


Hi,
Le lundi 01 novembre 2004 à 12:55 +0100, Reimar Döffinger a écrit :

> > >>-.B greyscale
> > >>+.B greyscale | nogreyscale
> > >
> > >How should those "no"-variants be indicated? It's cuurently
> > >inconsistent. I found 4 times this variant and 10 times something like
> > >(no)optionname
> > 
> > Sorry, my fault. I added the "flag | noflag" variants, without seeing the 
> > "(no)flag" options elsewhere. I simply noted that the toplevel flags 
> > don't mention noflag at all, other than the global statement "Every 
> > 'flag' option has a 'noflag' counterpart".
> 
> Not sure if it's a fault... I'm not sure which variant I like better, it
> just should be consistent, so we must decide on one.
> So the (no)optionname variant is official? or should both variants be
> written out? If the latter, both on one line or each on its own?

The (no) variant seem, from my point of view to be the official way.

Anyway, patch committed. I hope I'm not gonna get a shuttle reservoir
worth of cola. ;-)

Regards,
Guillaume




More information about the MPlayer-dev-eng mailing list