[MPlayer-dev-eng] Re: [PATCH] don't skip first mp3 frame

[D Richard Felker III]

On Tue, Mar 30, 2004 at 07:30:37PM -0800, Nehal wrote:
> On Tue, 30 Mar 2004 22:11:42 -0500
> D Richard Felker III <dalias at aerifal.cx> wrote:
> 
> > On Tue, Mar 30, 2004 at 06:10:57PM -0800, Nehal wrote:
> > > Hi Albeu,
> > > 
> > > i downloaded the broken-first-frame.mp3 and tested it,
> > > apparently the starting position skips the header if it
> > > doesn't start at the beginning of the file. it then searches
> > > for the next header data(which in this case, it finds what it
> > > thinks is a frame header inside the audio data of first frame
> > > which is why it incorrectly detects it as 48000)
> > > 
> > > anyways here is a revised patch, plays the mp3 fine now
> > > 
> > > Nehal
> > 
> > Thanks for debugging the problem! Unfortunately your patch is
> > corrupt though (full of ^M's :).
> > 
> > Rich
> 
> it's CF for win32, but i thought 'patch' strips these
> automatically, hmm, oh well, anyways here it is, again, hopefully
> it's ok

Was this patch ever applied? IIRC at the time I refused to commit it
myself because I couldn't do thorough tests, but it looks right.
Anyway, no one seems to be stepping forward to test, so I'm going to
commit this soon and let our users do the testing after the next
release... :))

Rich