[MPlayer-dev-eng] [PATCH] Possible bug in libao2/ao_alsa.c

[Salvatore Falco]

Hi all, I'm back again.
The included patch is the one missing last time (^^;).
As you can see the patch is for ao_alsa.c, not for ao_alsa1x.c.
I just said I could trace back the change from one to two arguments for
snd_pcm_hw_params_get_buffer_size function to version 1.42 of ao_alsa1x.c,
made January 11th; this code later went into ao_alsa.c.

	Best regards, Salvatore Falco
-- 
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?
-------------- next part --------------
diff -Nur MPlayer-20040527.orig/libao2/ao_alsa.c MPlayer-20040527/libao2/ao_alsa.c
--- MPlayer-20040527.orig/libao2/ao_alsa.c	2004-05-13 00:56:55.000000000 +0200
+++ MPlayer-20040527/libao2/ao_alsa.c	2004-05-27 18:46:44.000000000 +0200
@@ -670,12 +670,12 @@
 
 
       // gets buffersize for control
-      if ((err = snd_pcm_hw_params_get_buffer_size(alsa_hwparams, &bufsize)) < 0)
+      if ((err = snd_pcm_hw_params_get_buffer_size(alsa_hwparams)) < 0)
 	{
 	  mp_msg(MSGT_AO,MSGL_ERR,"alsa-init: unable to get buffersize: %s\n", snd_strerror(err));
 	}
       else {
-	ao_data.buffersize = bufsize * bytes_per_sample;
+	ao_data.buffersize = err * bytes_per_sample;
 	  mp_msg(MSGT_AO,MSGL_V,"alsa-init: got buffersize=%i\n", ao_data.buffersize);
       }