[MPlayer-dev-eng] [PATCH] vo_quartz: better (?) fullscreen support, better re-opening

Diego Biurrun diego at biurrun.de
Fri May 7 03:19:29 CEST 2004


Romain Dolbeau writes:
> The attached patch fixes vo_quartz:
> 
> 1) opening multiple movies no longer open multiple windows,
>     but instead re-use the old one. Include fixing a memory
>     leak and potential QuickTime trouble when never closing
>     a sequence.
> 
> 2) if mplayer was in fullscreen mode when changing movies,
>     the new movies starts in full-screen mode too. I'm not
>     quite sure this is what the driver is supposed to do,
>     even though I find it convenient (there's still a flicker,
>     as vo_quartz resize the window to be able to return to
>     windowed mode with the proper sized window).

Hmm, some of this is usually achieved with the -fixed-vo option.

You should try to mimic what other vo drivers do.  If I am not
mistaken the correct behavior is to respect the command line options.
So if I start a few movies with -fs and switch to windowed mode in
between by pressing f, it will switch back to fullscreen mode when the
next file starts and vice versa.  I'm not sure if I like this default
behavior, though.

Diego




More information about the MPlayer-dev-eng mailing list