[PATCH] [RESEND] wma2ogg (was: Re: [MPlayer-dev-eng] lost patches)

[Diego Biurrun]

VMiklos writes:
> On Tue, 4 May 2004, Diego Biurrun wrote:
>
> > 	print "\nThis program holds to BladeEnc for mp3!\n(See the source
> > for more information!)\n";
> >
> > Dunno what "holds" is supposed to mean here.
>
> Peter prefers bladeenc and hates lame. so the message could be:
> "Using lame - WARNING - this is not optimal!"

OK, this message then.

> >   error ("Unambiguously allotted files. (You've selected the all and
> > other files too!)");
> >
> > This message is extremely ambiguous.
>
> i haven't noticed this ;-)
>
> use wrongly instead of unambiguously

OK, and what is

  (You've selected the all and other files too!)

supposed to mean?

Then I found a bug simply by running the program without arguments:



silver:/usr/src/mplayer/main/TOOLS$ ./wma2ogg.pl

wma2ogg 0.3.3
Peter Simon <simon.peter at linuxuser.hu>

Usage: wma2ogg [OPTIONS] (-f FILE1 | -f FILE2 ... | -a)

-f, -file         filename
-a                convert all wma files in the current directory

OPTIONS:
-t                output filetype (ogg, mp3) [default=ogg]
-lame             I wanna use L.A.M.E. sure enough!
-br               bitrate (kb/s) [default=from the wma]
-del              remove wma file(s) after the encoding

There is no selected file!
Exiting program.


This program holds to BladeEnc for MP3!
(See the source for more information!)


Usage: wma2ogg [OPTIONS] (-f FILE1 | -f FILE2 ... | -a)

-f, -file         filename
-a                convert all wma files in the current directory

OPTIONS:
-t                output filetype (ogg, mp3) [default=ogg]
-lame             I wanna use L.A.M.E. sure enough!
-br               bitrate (kb/s) [default=from the wma]
-del              remove wma file(s) after the encoding

The needed 'oggenc' program is missing, see: http://www.vorbis.com!
There is no selected file!
Exiting program.



This should not get printed multiple times.  I can fix this by
converting

  print "\n$errtext\nExiting program.\n\n";

into

  die "\n$errtext\nExiting program.\n\n";

but I suppose you also wanted to print out information about which
programs are missing.

Please fix this and improve the messages, I've attached my version 3.4
with some improvements for you to work on.  Nevertheless in the
current form the tool is rejected.
Regards

Diego