[MPlayer-dev-eng] Re: More tests ran

[adland]

> > playback incorrect sound with errors
> > FAAD: Failed to decode frame: Maximum number of bitstream elements exceeded
> 
> Does this also happen with the 2.0 release?
No it did not.
I traced the bug to an error in sbr_syntax.c from their CVS code.
I also have sent the bugreport and fix to the devels for libfaad2.

id 947540 in their bugtracker on sourceforge.
http://sourceforge.net/tracker/
index.php?func=detail&aid=947540&group_id=704&atid=100704

if you want you can also download patch from 
http://adland123.tripod.com/libfaad2_cvs_sbr_fix

comparison test results SBR (also called HE AAAC or AAC Plus)
./mplayer -vo null -benchmark samples/test_heaac.mp4

Alt patch - without -DFIXED-POINT option
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.972s Sys:  18.695s =   19.668s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  4.9436% Sys: 95.0564% = 100.0000%

Alt patch - with -DFIXED-POINT option
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.742s Sys:  19.010s =   19.752s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  3.7555% Sys: 96.2445% = 100.0000%

my cvs sync patch with sbr fix
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.500s Sys:  19.336s =   19.836s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  2.5205% Sys: 97.4795% = 100.0000%

Thanks