[MPlayer-dev-eng] Re: [PATCH] sync libfaad2 CVS 5-1-04 large

[adland]

> I went to great lengths
> to remove all the uint16_t's from cfft.c and several other files, as
> well as adding some better fixed point asm for x86.
 
just curious because these changes you did do not show up in the CVS info
for this file libfaad2/cfft.c

V1.2 synced with current cvs (7 months ago)
V1.1 libfaad2 v2.0rc1 imported

did you do this on the original import?
in fact most files in this library just showed syncs with CVS.

I did not intentionally remove any changes in this patch.
just updated with newer CVS code.
 
> - Try to keep up with upstream faad and hope they fix the horrible
>   performance. (Not likely since they're windows morons...)

Well no one would fix the compile issues without syncing with upstream.
So I just did this just to try to get them fixed.
 I think if you have better code then forget syncing with upstream.

> - Apply my patches and forget about sync with upstream.
Just curious where are your patches to try?
 
> - Beg someone to write an AAC decoder for libavcodec and remove this
>   shitty code from MPlayer cvs entirely.

not within my capabilities.