[MPlayer-dev-eng] [PATCH] minor small updates

[Diego Biurrun]

adland writes:
> here are some small updates

Could you please update your patch?  It does not apply anymore.

Furthermore you have done some changes to external libraries, you
should try to send these changes upstream and/or check if it is
already fixed upstream.  If it gets accepted upstream or if it's
already included upstream, the probability of us accepting the patch
is far higher.

> libfaad2/output.c
> output.c: In function `dither_output':
> output.c:203: warning: integer constant is too large
> for "long" type
> output.c:203: warning: integer constant is too large
> for "long" type
> output.c:208: warning: integer constant is too large
> for "long" type
> output.c:208: warning: integer constant is too large
> for "long" type
> output.c:214: warning: integer constant is too large
> for "long" type
> output.c:214: warning: integer constant is too large
> for "long" type

Hmmm, if we are looking at that file already, under Cygwin on Windows
2000 I get these strange assembler messages (as 2.15.90 20040312):

{standard input}: Assembler messages:
{standard input}:1009: Error: value of -131 too large for field of 1 bytes at 16
98
{standard input}:1125: Error: value of -133 too large for field of 1 bytes at 19
95
make: *** [output.o] Error 1

Does anybody have a clue?

> 46c46
> < #define ROUND64(x) (doubletmp = (x) + Dither.Add + (int64_t)0x001FFFFD80000000L, *(int64_t*)(&doubletmp) - (int64_t)0x433FFFFD80000000L)
> ---
> > #define ROUND64(x) (doubletmp = (x) + Dither.Add + (int64_t)0x001FFFFD80000000ULL , *(int64_t*)(&doubletmp) - (int64_t)0x433FFFFD80000000ULL)

This part of your patch is bogus, looks like you missed the -u option
to diff.

BTW, any volunteers to update libfaad?

Diego