[MPlayer-dev-eng] [PATCH] YUV support for vo_quartz, at last

[Camillo Lugaresi]

At 16:35 -0400 30-04-2004, Nicolas Plourde wrote:
>>At 9:14 +0200 30-04-2004, Romain Dolbeau wrote:
>>>Hello all,
>>>
>>>At last, working YUV support for the Quartz video
>>>output module. Full screen and OSD are supported
>>>(for some reason unknown yet, OSD in YUV is on top
>>>of the screen instead of bottom. Also, in fullscreen,
>>>OSD is on the picture and not in the black bar like
>>>it's done with vo_sdl). vo_quartz support suboptions
>>>to force one (or more) of the rendering mode
>>>(e.g., -quartz use_uyvy)
>>
>>I see this was done by using QuickTime, like SDL does. At this 
>>point, there is no reason to call it vo_quartz: it would make more 
>>sense to make it a separate driver and call it vo_quicktime. The 
>>event handling code should then be moved to a separate file that 
>>can be used by both modules.
>>
>>Not that using QuickTime is a bad idea! Quite the opposite: 
>>CoreGraphics (Quartz 2D API) was never meant for fast image 
>>blitting, and QuickTime's image support is always going to 
>>outperform it. All I'm saying is that you should change the 
>>driver's name to reflect what it really does.
>>
>>Camillo Lugaresi
>
>Quicktime framework is used for color space conversion only.

Looking at Romain's patch, it looks like QuickTime is doing most of the work.

>And on OSX
>Your are always using quartz compositor at some point, OpenGL, 
>Quicktime, Quartz 2d, Quickdraw.
>
>That why I named it quartz.

I see your point. However, that's exactly why "quartz" is not very 
useful as an output driver name. Since the Quartz compositor always 
comes into play when drawing to the screen in Mac OS X, it does not 
help differentiate between different Mac drivers. That's why I think 
the driver name should reflect the API it's based on (CoreGraphics, 
QuickDraw, QuickTime, OpenGL...).

Camillo Lugaresi