[MPlayer-dev-eng] [PATCH] fix for url escape issue - try 2

Bertrand Baudet bertrand_baudet at yahoo.com
Sat May 1 00:14:55 CEST 2004


Looks ok to me except for the cosmetic.
Your patch shouldn't change identation on code that hasn't change. It makes 
reading the patch more confusing. (see DOCS/tech/patches.txt sect.4 )

Please resend.

Bertrand

On Friday 30 April 2004 10:39, adland wrote:
> I am including a patch which is a second attempt at
> fixing the problems with url escape.
>
> files affected are just 3
> libmpdemux/open.c
> (remove unescape/escape function from this code)
> libmpdemux/http.c
> (remove escape function use from this code)
> libmpdemux/url.c
> fix issues with url_escape and url_unescape functions
> add code to url_new function which escapes url
>  automatically on creation.
>
> some initial testing showed it worked well for many
> different situations http,mms,rtsp .
>
> please test/consider as well with other urls etc
>
> thanks
>
>
>
>
> __________________________________
> Do you Yahoo!?
> Win a $20,000 Career Makeover at Yahoo! HotJobs
> http://hotjobs.sweepstakes.yahoo.com/careermakeover




More information about the MPlayer-dev-eng mailing list