[MPlayer-dev-eng] [PATCH] make wmv9 playback less verbose

[Diego Biurrun]

Michael Niedermayer writes:
 > On Friday 26 March 2004 04:12, D Richard Felker III wrote:
 > > On Fri, Mar 26, 2004 at 03:54:19AM +0100, Diego Biurrun wrote:
 > > > When playin wmv9 videos the console gets spammed badly with messages
 > > > like this:
 > > >
 > > >   Win32 Warning: Unlocking unlocked Critical Section 0x864fb18!!
 > > >
 > > > These messages are more confusing than helpful and they come by the
 > > > hundreds, which makes them annoying.  This patch changes the printf
 > > > calls to dbgprintf calls, which makes the messages appear only when
 > > > mplayer is called with -v -v.
 > > >
 > > > IIRC there have been complaints about these messages on -users and
 > > > here also.  I'd like to commit this, if there are no problems, so
 > > > somebody please check it.
 > >
 > > IMO commit. these stupid printf's at least need to be replaced with
 > > something. All the printf mess should be removed so we can eventually
 > > use stdout...
 > sure but that patch doesnt look correct:
 >      FF(RegCloseKey, -1)
 > -    FF(RegCreateKeyA, -1)
 >      FF(RegCreateKeyExA, -1)
 > ...
 > is it just me or does this patch change a few unrelated things like:
 > -  if (!strcmp(library, "tsd32.dll") || !strcmp(library,"vssh264dec.dll") || 
 > !strcmp(library,"LCMW2.dll"))
 > +  if (!strcmp(library, "tsd32.dll") || !strcmp(library,"vssh264dec.dll"))

You are right, sorry, this patch is not against the latest version of
loader/win32.c.  The updated patch below should do the trick, though.

Diego


--- loader/win32.c	25 Mar 2004 21:36:18 -0000	1.86
+++ loader/win32.c	26 Mar 2004 03:55:39 -0000
@@ -1381,7 +1381,7 @@
 #else
 	cs = (*(struct CRITSECT**)c);
 #endif
-	printf("Win32 Warning: Accessed uninitialized Critical Section (%p)!\n", c);
+	dbgprintf("Win32 Warning: Accessed uninitialized Critical Section (%p)!\n", c);
     }
     if(cs->locked)
 	if(cs->id==pthread_self())
@@ -1402,7 +1402,7 @@
     dbgprintf("LeaveCriticalSection(0x%x) 0x%x\n",c, cs);
     if (!cs)
     {
-	printf("Win32 Warning: Leaving uninitialized Critical Section %p!!\n", c);
+	dbgprintf("Win32 Warning: Leaving uninitialized Critical Section %p!!\n", c);
 	return;
     }
     if (cs->locked)
@@ -1411,7 +1411,7 @@
 	pthread_mutex_unlock(&(cs->mutex));
     }
     else
-	printf("Win32 Warning: Unlocking unlocked Critical Section %p!!\n", c);
+	dbgprintf("Win32 Warning: Unlocking unlocked Critical Section %p!!\n", c);
     return;
 }
 
@@ -1429,13 +1429,13 @@
 
     if (!cs)
     {
-	printf("Win32 Warning: Deleting uninitialized Critical Section %p!!\n", c);
+	dbgprintf("Win32 Warning: Deleting uninitialized Critical Section %p!!\n", c);
 	return;
     }
     
     if (cs->locked)
     {
-	printf("Win32 Warning: Deleting unlocked Critical Section %p!!\n", c);
+	dbgprintf("Win32 Warning: Deleting unlocked Critical Section %p!!\n", c);
 	pthread_mutex_unlock(&(cs->mutex));
     }