[MPlayer-dev-eng] Re: [PATCH] add support alpry lossless codec

[adland]

> > > -int expRegisterClassA(const void/*WNDCLASSA*/ *wc)
> > > +static int WINAPI expRegisterClassA(const void/*WNDCLASSA*/ *wc)
> 
> it's ok to change exp* to static, actually they should all be
> static, except the ones used directly by other files in loader/ or
> the dshow/dmo/vfw/acm interface implementations
> 
> 

actually this was a critical change for this patch - 
adding  WINAPI because otherwise when the external codec dll called 
this emulated function I would get a segfault otherwise.

I did previously check before changing this line
and no other files referenced this function directly (greped).

thanks for the help in this change