[MPlayer-dev-eng] Re: [Patch] Audio detection
behrisch at informatik.hu-berlin.de
Wed Mar 24 09:47:17 CET 2004
On Mon, Mar 22, 2004 at 06:11:09PM +0100, Alban Bedel wrote:
> Hi Michael Behrisch,
> on Mon, 22 Mar 2004 12:40:06 +0100 you wrote:
> > On Fri, Mar 19, 2004 at 03:12:41PM +0100, Alban Bedel wrote:
> > >
> > > There's a pb somewhere in your patch. On the first mp3 cd i took i
> > > alredy found i whole rip wich is not detected anymore. If you need i
> > > can upload some samples somewhere. Sadly i can't login to the mphq
> > > ftp, i have to ask Arpi about that.
> > Please try first to increase the 50 in the while (n<50 ...
> > I think the old code scanned the whole file if necessary because
> > the n was never incremented inside. If this does not work, please
> > upload.
> After increasing n to 1000 (500 wasn't enouth) it seems ok. I tested
> a couples cds and all worked correctly.
One could remove the "n<x" check entirely and always scan up to the end
but I think this would make startup slower (although it maybe resembles
best the behaviour before the patch).
Do as You wish and then apply please.
More information about the MPlayer-dev-eng