[MPlayer-dev-eng] [PATCH] fix asm deps [RESENT]

D Richard Felker III dalias at aerifal.cx
Thu Mar 18 02:50:11 CET 2004

On Thu, Mar 18, 2004 at 12:40:47AM +0100, Michael Niedermayer wrote:
> Hi
> On Wednesday 17 March 2004 18:50, Dirk Mueller wrote:
> > Hi,
> >
> > resending the patch. I've checked out gcc 2.95 and tested the patch with
> > it. it compiles fine with gcc 2.95.
> ok, it seems u missunderstood, the reason why the code is using MANGLE() 
> instead of "m" to access some variables is because it didnt work the other 
> way with some version of gcc, so it doesnt help if it compiles with ur gcc 
> 2.95.?, one or more of these asm statements will fail to compile or lead to 
> incorrect code with some other gcc version, and theres also no reason why the 
> problem should be fixed in this strange way anyway, the correct fix is to add 
> attribute_used to the variables and define it to attribute((used)) if gcc 
> supports it

Michael, his patch doesn't get rid of the MANGLE stuff as far as I can
see. It just adds useless dependencies which are unreferenced in the
actual asm.

BTW, another way around this problem would be to make a non-static
array of type void * to point to all the unused symbols, so gcc can't
throw them away.


More information about the MPlayer-dev-eng mailing list