[MPlayer-dev-eng] [PATCH] vo_directfb minor updates
diego at biurrun.de
Fri Mar 5 07:14:22 CET 2004
Jiri Svoboda writes:
> > > Just few coments (my fault I didn't read man page before):
> > > -there is only -vo directfb and NO -vo directfb2 and never was.
> > > vo_directfb.c or vo_directfb2.c is choosen at configure/compile
> > > time depending on the DirectFB version
> > Does vo_directfb.c support the same options? A cursory glance through
> > the sources leads me to believe that vo_directfb.c has no suboptions..
> Yes. vo_directfb.c does not support any suboption.
OK, this should be mentioned in the docs, though.
> It is outdated now and was designed for very old DirectFB version.
How about removing it then? Is it still useful?
> > > -as I stated before most options are common between
> > > vo_directfb and vo_dfbmga. Maybe it would be better to group
> > > the togeather.
> > You just copied and pasted the descriptions from the dfbmga section
> > anyway, so maybe is should point there. Probably it should be the
> > other way around since vo_directfb is the more general vo.
> Yes and No. The most of option are same - but they have other defaults.
> Also vo_directfb2 does not support matrox specific features.
OK, I'll think about if and how to unify them.
More information about the MPlayer-dev-eng