[MPlayer-dev-eng] [PATCH] ao_alsa alsa_device string handling fixes

[Reimar Döffinger]

Hi,

> it's me again. Your patch is as i said basically ok,
> but i just recognized ( cause my compile aborted ),
> that your change from alsa_device from a pointer into
> an array breaks some other code in ao_alsa.c .

File dates were broken in my copy, so 'make' didn't recompile and I 
missed that :-(

> That should be correct corrected first ;)

Did that. Corrected patch attached.

But whoever wrote large parts of the code seems to have had no idea of 
how C works :-(((... There are still lots of _very_ wrong things...
Those *(token_str + i3) constructs really should be converted to 
token_str[i3].
Line 1087 'if (str_status != "open")' looks very fishy as well, etc.

Greetings,
Reimar Döffinger
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: alsa_stringfixes.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040627/ce0f6c33/attachment.txt>