[MPlayer-dev-eng] [PATCH][RESEND] XV page flipping sync

[Joey Parrish]

On Wed, Jun 23, 2004 at 09:23:11PM +0300, Ivan Kalvachev wrote:
> Somehow I don't like both patches.
> I agree it is pointless to have BOTH XFlush and XSync, but I'm not sure that
> XFlush is always the one that should be removed.

> I particularry don't like this:
> @@ -595,12 +593,9 @@
>                     (vo_fs ? vo_dheight - 1 : vo_dheight) + vo_panscan_y);
>      }
>      if (num_buffers > 1)
> -    {
>          current_buf =
>              vo_directrendering ? 0 : ((current_buf + 1) % num_buffers);
> -        XFlush(mDisplay);
> -    } else
> -        XSync(mDisplay, False);
> +    XSync(mDisplay, False);
>      return;
>  }

> Are you sure this is the right solution for all cases?
> Anyway are you sure that this syntax doesn't have some purpose?

I'm not sure about any of it.  The original patch wasn't mine, I was
just asked to extend it.  I won't commit any of it because it's not my
code and I know nothing about x11.  Somebody else should decide if it's
right or not.  In any case, I've been patching my local copy with the
original for a few weeks and I've seen no issues with xv.

YMMV,
--Joey

-- 
"Living in the complex world of the future is somewhat
like having bees live in your head.  But, there they are."