[MPlayer-dev-eng] [PATCH] Real Audio/Video support for Mac OS X

[Diego Biurrun]

Donnie Smith writes:
> I'd be surprised if I didn't make any mistakes with the DOCS-patch,
> someone familiar with the XML format used (which is new to me): please
> check it carefully and suggest possible fixes.

I attached an updated version, please resend your patch including it
and a fix for some of the suggestions I'll make below.

> Note that it does NOT happen with -ao sdl, so I'm blaming it solely on
> the macosx ao.

According to Dan Christiansen, its author, ao_macosx is badly broken,
so I guess you can disregard this as long as it works with -ao sdl.

> Also, note that RealOne for Mac OS X doesn't ship with all codecs.
> Instead, the player downloads them when needed (great "honest" way of
> tracking what "uncommon" codecs users are intrested in, I guess). They
> are permanently stored though, so you can use them with mplayer once
> you have them. Perhaps a package should be created and put on
> http://www.mplayerhq.hu/homepage/dload.html ?

Yes, we'll put a codecs package up for download.  Could you prepare
and upload it to incoming, please?

> -	"Florian Schneider & A'rpi", // win32 dlls support by alex
> +	"Florian Schneider & A'rpi", // win32 dlls support by alex, mac os x shlb support by Donnie Smith

Since I am a pedantic pest when it comes to spelling I would write
"Win32 DLLs support by alex, Mac OS X shlb support by Donnie Smith",
but feel free to disregard this ;-).

> -	"A'rpi", // win32 dlls support by alex
> +	"A'rpi", // win32 dlls support by alex, mac os x shlb support by Donnie Smith

same here

> + Helper function to create a function pointer (from a null terminated (!)
> + pascal string) like GetProcAddress(). Some assembler is required due
> + to different calling conventions, for further details, see 
> + http://developer.apple.com/ samplecode/CFM_MachO_CFM/listing1.html .

The space in the URL is wrong, while you're at it, you could
capitalize Pascal and remove the trailing whitespace from the third
line.

> --- MPlayer-20040618.orig/DOCS/xml/en/codecs.xml	Wed May 12 00:50:05 2004
> +++ MPlayer-20040618/DOCS/xml/en/codecs.xml	Fri Jun 18 13:56:17 2004
> @@ -428,7 +428,15 @@
>  <note><para>
>  <application>RealPlayer</application> libraries currently
>  <emphasis role="bold">only work with Linux, FreeBSD, NetBSD and Cygwin on the x86,
> -Alpha and PowerPC (Linux/Alpha and Linux/PowerPC have been tested) platforms</emphasis>.
> +Alpha and PowerPC (Linux/Alpha and Linux/PowerPC have been tested) platforms and with Mac OS X</emphasis>.
> +</para>
> +<para>
> +On Mac OS X you must make sure <command>pncrt.Shlb</command> (including it's resource fork!) is in the same directory

I'd rather use <filename> instead of <command>.

> +<command>ditto -rsrcFork "RealOne Player.app/Contents/MacOS/pncrt.Shlb" "RealOne Player.app/Contents/MacOS/Library/Codecs"</command>

This will look even better in <screen> instead of <command>

> +<command>GetDiskFragment() failed with error -2804: &lt;&lt;Unknown disk fragment&gt;&gt;&lt;&lt;Unknown disk
> +fragment&gt;&gt;&lt;pncrt.Shlb&gt;&lt;&gt;</command>

This should also be in <screen> tags and you should insert a linebreak
at the point where the original message is wrapped, <screen> does not
wrap lines automatically (similar to <pre> in HTML).

>  
> -
> +echocheck "Mac OS X codec SHLB support"

Don't remove that blank line above echocheck, the readability of the
configure script is bad enough as it is.

> +if test "$_macshlb" = auto ; then
> +  if test "$_macosx" = yes ; then
> +    _macshlb=yes

Hmm, shouldn't this work on Linux PPC as well?

Diego