[MPlayer-dev-eng] [PATCH] Real Audio/Video support for Mac OS X
Reza Jelveh
reza.jelveh at tu-harburg.de
Sat Jun 19 01:34:33 CEST 2004
hi,
my cubes hdd died for yet unknown reasons so i couldnt test as fast as expected. nontheless the patch looks ok from what i see. ill test on my brothers ibook when possible.
however theres too things i wonder about.
1. darwin supports unix dlopen for opening shared libraries in osx. isnt there a more common way to implement the symbol loading?
2. i think it would be best to split the os specific code or generic code from vd_realvid.c or ad_real* and put it in a different file. that would make the source more organized and readable(however that cleanup should be done in a different commit as i suppose it would count as cosmetics).
otherwise the patch looks good to me. but i didnt investigate in detail. i will check as soon as i get my hands on the lappy.
as for ah_my_goddess*.rm. i think that file is broken and doesnt even play in normal realplayer(i might be wrong tho). but i think i had the same desync behaviour in linux. and for high cpu usage desync thats a not really an error but rather you should try it with framedrop that might work against the desynchronisation?
regards
reza jelveh
More information about the MPlayer-dev-eng
mailing list