[MPlayer-dev-eng] [PATCH] many libao2 fixes (resubmit)

Sascha Sommer saschasommer at freenet.de
Fri Jun 18 15:36:08 CEST 2004


> > note: i've submitted before with no reply, so this is a
> > resubmission, also has some improvements to previous patch. 
> > 
> > this patch fixes the following:
> > - ao_oss.c , SNDCTL_DSP_RESET is sent to sound card, this should
> > be SNDCTL_DSP_SYNC otherwise the remaining buffers don't play
> > - ao_win32.c , volume is reset to value before mplayer was
> > started, this is annoying and unnecessary, removed
> > - ao_win32.c , made get_space() more efficient
> > - ao_win32.c , fixed buffer bug that could (under rare
> > circumstances) cause a crash
> > - ao_win32.c , uninit() doesn't wait until remaining buffers
> > play- ao_sdl.c , uninit() doesn't wait until remaining buffers
> > play- ao_sdl.c , made get_space() more efficient
> > - ao_sdl.c , buffer underruns on many systems so changed default
> > sample size to 2048
> > - ao_sdl.c , volume get/set control was wrong
> > - ao_sdl.c , data was mixed onto itself, causing distored sound
> > 
> > Nehal
> > 
> as per request, i have made some changes (removed any cosmetic
> changes to make patch easier to read) here it is again
> 

Just for the record. The good parts of this have been applied.
The changes to the SAMPLESIZEs caused buffering/noise
problems for BSD and Windows, therefore rejected.

Sascha




More information about the MPlayer-dev-eng mailing list