[MPlayer-dev-eng] [PATCH] [configure] freetype depends on iconv

Diego Biurrun diego at biurrun.de
Fri Jun 11 17:31:01 CEST 2004


Diego Biurrun writes:
> Joey Parrish writes:
> > On Wed, Jun 02, 2004 at 02:03:30PM -0400, D Richard Felker III wrote:
> > > On Wed, Jun 02, 2004 at 10:00:08AM -0500, Joey Parrish wrote:
> > > > I agree with this patch, but I've also found that I can hack in some
> > > > block comments and get freetype support both compiled and working for
> > > > me without iconv.  I know that my method is an unacceptable hack,
> > > > probably dependant on my characterset.  But if it's possible to have
> > > > freetype without iconv and not break everything, that would be great.
> > > 
> > > Agree. Can you convert your block comments into "#ifdef HAVE_ICONV"
> > > and submit a patch?
> > 
> > Yes, but don't be surprised to read it and find out that it doesn't work
> > for everyone.  I don't know anything about freetype or iconv, so I make
> > no promises about the quality of the patch.  Someone who knows about
> > these things should review it before commit.
> 
> In any case this is orthogonal to my patch.  If nobody objects I'll
> commit this in a few days, the iconv dependency can be removed later
> on.

Applied.

Diego




More information about the MPlayer-dev-eng mailing list