[MPlayer-dev-eng] [PATCH] JACK audio output module

[Reimar Döffinger]

Hi,

>>If bio2jack is a library, it shouldn't be included in MPlayer directly 
>>IMHO, but instead configure should check for an installed version and 
>>enable the ao only when it's available (except if --enable or --disable 
>>is given, of course).
> 
> Not in this case - bio2jack is intended to be statically linked and there
> is no *.so version. In author's own words:
> "This library is intended only for static linking as it is small and there 
> is no need to require yet another library for a user to install. So 
> please, statically link to this library."

yes, "statically link", not hack it into your code ;-). The package from 
sourceforge creates a libbio2jack.a file. If you put that in your 
library path, you can link to it simply by passing -lbio2jack to gcc.

>>Otherwise we will always need a maintainer to keep the included version 
>>of bio2jack in sync with the sourceforge version. My experience is that 
>>this just won't work and sooner or later somebody will start hacking our 
>>version instead of patching the original on sourceforge.
> 
> IMHO it's not a big problem. Even if someone wants to hack version
> included in this patch to fit specific mplayer needs, I think it's
> still ok. Version included with xmms plugin AFAIK also differs at some
> point from the SF version. I think it's a good side of small statically
> linked libraries - they provide some general platform which you can
> (but dont't have to) tune to your own needs.

The problem is that we will need somebody to look after it and apply 
patches that go into sourceforge code, etc. I think we just don't have 
_any_ developer resources to waste, there is already so much code that 
is completely unmaintained...

Greetings,
Reimar Döffinger