[MPlayer-dev-eng] -Wall

[James Courtier-Dutton]

D Richard Felker III wrote:
> On Fri, Jun 04, 2004 at 03:35:05PM +0100, J. Grant wrote:
> 
>>>Not entirely opposed, but I disagree. It prints so much useless spam
>>>that it's hard to see real bugs.
>>
>>The "useless spam" is just a confused compiler, all compilers do this.
>>If it's confused, IMO we should clarify:  i.e. initialise variables to 0
>>to stop "might be used uninitialized in this function", and correct
>>casts etc, but we would never be aware of these unless some people
>>locally add -Wall.
> 
> 
> NO, ARE YOU FUCKING STUPID?!?! The whole reason the code was written
> that was is that initializing to zero takes TIME!!!!! MPlayer is not
> written to be slow crap like other players...
> 
> Rich
> 

I have not looked at the code, but if it is just the compiler getting 
confused, and that variable is always properly used, then don't change 
the code. People are cleverer than compilers, and performance is important.

I agree with Rich on this point.

Cheers
James