[MPlayer-dev-eng] [PATCH] [configure] freetype depends on iconv

D Richard Felker III dalias at aerifal.cx
Wed Jun 2 20:03:30 CEST 2004


On Wed, Jun 02, 2004 at 10:00:08AM -0500, Joey Parrish wrote:
> On Mon, May 31, 2004 at 02:34:45PM +0200, Diego Biurrun wrote:
> > While trying to get the GUI compiled under Cygwin I noticed that 
> > freetype depends on iconv.  The check for iconv is done later than the 
> > check for freetype, though.  My patch moves the iconv check up so it is 
> > before freetype and disables freetype if iconv is not present.  I put 
> > the iconv check together with the other internationalization / character 
> > set checks, if you know a better place or if iconv depends on something 
> > I did not notice, please shout.
> 
> I agree with this patch, but I've also found that I can hack in some
> block comments and get freetype support both compiled and working for
> me without iconv.  I know that my method is an unacceptable hack,
> probably dependant on my characterset.  But if it's possible to have
> freetype without iconv and not break everything, that would be great.

Agree. Can you convert your block comments into "#ifdef HAVE_ICONV"
and submit a patch?

Rich




More information about the MPlayer-dev-eng mailing list