[MPlayer-dev-eng] [PATCH] mplayer/metacity fs bug

[Curtis Magyar]

On Tue, 2004-06-01 at 09:00 +0900, Attila Kinali wrote:
> >  
> > +/*** EWMH state actions ***/
> > +#define _NET_WM_STATE_REMOVE        0    /* remove/unset property */
> > +#define _NET_WM_STATE_ADD           1    /* add/set property */
> > +#define _NET_WM_STATE_TOGGLE        2    /* toggle property  */
> 
> 
> Please rename these 3 defines to MP_X11_NET_WM...
> Otherwise it looks ok. Diego, could you apply this patch
> if nobody has any objections ?
> Thanks

Sorry to butt in, I am very happy someone took the time to track down
this bug.  I think the naming should remain the way it is though, as
thats how it is in the EWMH spec:

http://freedesktop.org/Standards/wm-spec/index.html#id2768769

At the bottom of that section it says: 


To change the state of a mapped window, a Client MUST send a
_NET_WM_STATE client message to the root window (window is the
respective window, type _NET_WM_STATE, format 32, l[0]=<the action, as
listed below>, l[1]=<First property to alter>, l[2]=<Second property to
alter>). This message allows two properties to be changed
simultaneously, specifically to allow both horizontal and vertical
maximization to be altered together. l[2] MUST be set to zero if only
one property is to be changed. l[0], the action, MUST be one of: 

_NET_WM_STATE_REMOVE        0    /* remove/unset property */
_NET_WM_STATE_ADD           1    /* add/set property */
_NET_WM_STATE_TOGGLE        2    /* toggle property  */