[MPlayer-dev-eng] [PATCH][BUG] Incorrect memleak fix code in input/input.c might cause incorrect free

[Alexander Strasser]

Hi Shachar,
On Mon, Jul 26, 2004 at 05:59:42PM +0200, Shachar Raindel wrote:
> > Just a view things:
> > >    if( mp_input_parse_config(file)) {
> > > -    free(file); // release the buffer created by get_path()
> > > +    //    free(file); // release the buffer created by get_path()
> > >    }
> > >    else {
> > This doesn't look to nice, but maybe i'm blind again.
> > I would suggest:
> >     if( !mp_input_parse_config(file)) {
> > 
> > > +  free(tmpbufptr);
> > Maybe the freeing comment should be appended here.
> > 
> >   Alex (beastd)
> > 
> 
> I agree. The patch was written under time presure, and therefore I
> hadn't had time to make it pretty. I should clean-up my tree at home
> soon, and send some cleanup patches, so that I will not have so much
> CVS merge problems....
Do you want to resend a cleaned up patch?
If not i'm going to send one and apply it asap,
because I want to correct my mistake asap.

  Alex (beastd)