[MPlayer-dev-eng] [PATCH] volume control for arts audio output

[Reimar Döffinger]

Hi,
>>ao_arts.c doesn't have volume control. I't seems that arts doesn't
>>have an interface for hardware mixers. Hence we have to use oss or alsa
>>mixers.
>>
>>The following patch adds volume control via the oss mixer. The code
>>is copied from ao_oss.c with minor changes.
> 
> Any comments about this patch ?

There is ongoing work to automatically insert af_volume and changing 
volume via software when the ao doesn't support it. I think this would 
be the cleaner (although slower, but would you use arts if speed is 
important?) solution.
Another possible solution would be to enable mixer.c to use OSS, ALSA 
etc. mixers directly when speficied so on the commandline...
But it doesn't make sense if all aos now start duplicating the mixer 
code from ao_alsa and ao_oss, I think.

Greetings,
Reimar Döffinger