[MPlayer-dev-eng] [PATCH] new codec AIFF PCM Audio support

[Roberto Togni]

On 2004.07.17 08:38, Jake Luck wrote:
> 
> * added AIFF PCM playback
> * properly skips Apple's embedded ID3 tags
> * supports 16bit 44.1kHZ (for now)
> * diffed against latest CVS
> 
> enjoy.
A few comments about your patch.

When you add support for a new container, you should keep codec and  
demuxer as independant as possible.

If audio contatined in AIFF is standard pcm (as in your case), you  
should write you demuxer so that is uses ao_pcm.c, there is no need to  
add your own decoder (that btw does nothing, it just pass data  
unchanged from input (demuxer ) to output (audio out)).

That way you'll be able to easily support other audio codecs in AIFF,  
since afaik aiff can also have mace3/6, a/ulaw, and others.

So, you should parse header (FORM, COMM and such) in the demuxer, and  
fill parameters needed for decoding in sh->audio structure and, if  
needed, sh->audio-wf (WAVEFORMATEX).
You should not add anything to the sh_audio_t structure.
Then you fill audio format with a standard pcm format or, if noone  
apply, with your own format/fourcc: in this case add it to the pcm  
formats and patch ao_pcm (if needed) to handle it.

Another note: no need to patch codec-cfg.c, the part you patched is  
commented out (#if 0) anyway.

Don't feel discouraged by the negative comments, MPlayer is a very  
complex software and it takes some time to get used to it's design  
details.

If you have questions, feel free to ask. It may take a few days to get  
an answer, but we try to comment on every patch.

> 
> jake
Ciao,
 Roberto