[MPlayer-dev-eng] [PATCH] mga_vid for 2.6 - updated

[scognito at libero.it]

On 08/07/2004 20:15:43, Ferdinand O. Tempel wrote:
> Hi,
> 
> I took the remarks Attila made in #mplayerdev and a problem report
> someone *did* send me this week, and produced the following, updated
> patch against current CVS. If only someone would have reported this
> stuff to me or on a mailinglist sooner, instead of just complaining 
> on
> IRC, then maybe there would have been less problems with this stuff 
> in
> the firstplace.
> 
> Changes:
> - Fix module parameter handling to deal with arrays
> - Honour default behaviour, and put the default mga_vid device on
> major
> number 178. Use 'major=0' as module parameter to have the kernel
> dynamically generate a major number.
> 
> Note: The warnings which appear when building the module seem to be
> warnings generated by issues in the kernel code, not mga_vid.
> 
> DISCLAIMER:
> There are likely still bugs in this code. I did my best to find them,
> at
> least for 2.6. I have *NOT* built this updated module on 2.4 let 
> alone
> tested it. It *SHOULD* work on 2.4, however, as in the past I tried 
> to
> take great care in not breaking that part. If you *DO* find bugs, or
> have any problems, contact *ME* via email, or send something to the
> appropriate mailing lists, which I tend to follow by browsing
> archives.
> I'm not a mindreader, so include a *DECENT* bugreport. See
> http://www.chiark.greenend.org.uk/~sgtatham/bugs.html for hints.
> Thanks.
> 
> PS: The latest version of this patch can always be found at
> http://www.linuxops.net/~pw/mga_vid/
> 
> --
> Regards,
> 
> Ferdinand O. Tempel
> 
> Your friendly neighborhood linuxops.net administrator.
> 

Doesn't compile here (debian sid, linux 2.4.26):

Zelda:~/mplayer/main/drivers$ make
make mga_vid.o mga_vid_test
make[1]: Entering directory `/home/scognito/mplayer/main/drivers'
cc -O2  -D__KERNEL__  -DMODULE           -include /lib/modules/`uname
-r`/build/include/linux/modversions.h -Wall -I/lib/modules/`uname
-r`/build/include -I/lib/modules/`uname -r`/build/include/asm -c mga_vid.c
In file included from /lib/modules/2.4.26/build/include/linux/spinlock.h:6,
                 from /lib/modules/2.4.26/build/include/linux/module.h:11,
                 from mga_vid.c:45:
/lib/modules/2.4.26/build/include/asm/system.h: In function `__set_64bit_var':
/lib/modules/2.4.26/build/include/asm/system.h:190: warning: dereferencing
type-punned pointer will break strict-aliasing rules
/lib/modules/2.4.26/build/include/asm/system.h:190: warning: dereferencing
type-punned pointer will break strict-aliasing rules
mga_vid.c: In function `cleanup_module':
mga_vid.c:1853: error: structure has no member named `dev_handle'
mga_vid.c:1853: warning: implicit declaration of function `devfs_unregister'
mga_vid.c:1853: error: structure has no member named `dev_handle'
/lib/modules/2.4.26/build/include/asm/uaccess.h: At top level:
mga_vid.c:431: warning: `mga_max_cards' defined but not used
make[1]: *** [mga_vid.o] Error 1javascript:errsend ()
make[1]: Leaving directory `/home/scognito/mplayer/main/drivers'
make: *** [all] Error 2

Cheers, Piero.