[MPlayer-dev-eng] [PATCH] ve_xvid4.c catching up with xvid 1.0.0 beta3

[Nico]

Edouard Gomez wrote:

>Iive wrote:
>  
>
>>>I can accept these if they are properly documented!
>>>  xvidenc_max_bframes - I think that this enables B frames by default
>>>  xvidenc_vbr_overflow_control_strength
>>>  xvidenc_vbr_max_overflow_improvement
>>>  xvidenc_vbr_max_overflow_degradetion -hmm
>>>  xvidenc_vbr_container_frame_overhead - mencoder does it's own bitrate
>>>     calculations, pleace make sure you won't fool them.
>>>      
>>>
>
>Grab the documentation of the settings from the transcode xvid4.cfg
>file. All options are documented there.
>
>Nico wrote:
>  
>
>>Please, test this patch rather than the previous one in the thread: it 
>>handles correctly the special A/R cases (4/3 and 16/9);
>>xvid doesn't seem to know anything of "21:17" (never seen myself) and  
>>"2.21:1".
>>-static int xvidenc_hqacpred = 1;
>>+static int xvidenc_hqacpred = 0;
>>    
>>
>
>Oh  god  no,  i  prefer  you add  no'flags'  (nohqacpred,  notrellis  or
>nowhatever)  , better  than removing  features  which save  bits in  all
>cases.
>
>  
>
OK, so these settings should be enabled by default
packed
hq_ac
chroma_me
trellis

Right? and chroma_opt?