[MPlayer-dev-eng] fast_memcpy namespace collision

Torinthiel torinthiel at wp.pl
Tue Jan 20 06:58:41 CET 2004


On Mon, Jan 19, 2004 at 11:42:18PM +0100, Enrico Weigelt wrote:
> * D Richard Felker III <dalias at aerifal.cx> [2004-01-19 12:06:02 -0500]:
> 
> <snip>
> > Send a bugreport to suse or glibc developers (if it's in stock glibc).
> > Including a function named fast_memcpy violates ansi or posix or
> > something.
> Does it really ?
> What does POSIX say about functions in the base library ?
> Does it specify, that libc may not export other functions than the
> supported ones ?
> 
> 
> I personally would prefer renaming the function in the mplayer code.
> If you'd accept the patch, I'd go ahead and replace fast_memcpy by
> _mp_vo_fast_memcpy or something like that.

Well, this name is obviously bad. Everything that begins with _ is
reserved (was mentioned quite recently IIRC).
Torinthiel

> BTW: wouldn't it be better (for performance) to code this as an inline 
> function or a macro ? On most platforms it should be less than 5 ops

How do you want inline in C?
Torinthiel

-- 
 Waclaw "Torinthiel" Schiller       GG#: 542916, 3073512
   torinthiel(at)wp(dot)pl
   gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8  7346 2B6E 39F2 B069 01F1
 "No classmates may be used during this examination"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040120/db1008d4/attachment.pgp>


More information about the MPlayer-dev-eng mailing list