[MPlayer-dev-eng] [PATCH] SAMI seg fault

[Salvatore Falco]

> Hi,
> 
> > Current SAMI code expects a <P.*> after "START=" but many subs have
> > no <P> at all.. leading to a seg fault.
> > According to MS specs, this seems not required (even if all examples
> > use <P.*>).
> > Please consider the attached patch. Tested with both flavors of SAMI
> > subs.
> Any subreader.c specialists here or should I commit everything and get
> flamed after?

According to Microsoft Knowledge Base, in SAMI format each subtitle or
block of subtitles are defined as paragraphs, so they require a <P...>
tag at the beginning. Therefore any SAMI subtitle file without <P> tags
is broken.

However, it is a good idea to avoid segmentation faults, and I don't
think it will hurt to support broken files, until it is clear that they
_are_ broken.

	Best regards

		Salvatore Falco