[MPlayer-dev-eng] Re: [PATCH] -audiofile and rawaudio together

[Alban Bedel]

Hi Nico,

on Sun, 11 Jan 2004 23:58:57 +0100 you wrote:

> Hi,
> this patch permits to use raw audio files (not recognized by 
> demux_audio.c) together with -audiofile.
> The suboption to use is  :audiofile: e.g.

Did you tried -audio-demuxer ? Just setting it should be enouth,
so having another option that set audio-demuxer like demuxer
is set by on should be enouth. Or is there any other problem ?
 
> mplayer -rawaudio audiofile:format=0x2000 -audiofile file.ac3 file.m2v
> 
> leaving the suboption :on: unset (as default).
>
> Tested with ac3, pcm and mp2 files.
> 
> The patch is ugly, because I couldn't find a better way to make the code
>
> work with the ugly
> demux_open() demux_audio.c and especially demux_rawaudio.c , yet it 
> works ok (at least for me).

Yes, it's really ugly and can't be accepted as it is now. In particular
the rawaudio_on global that you putted back is 100% innaceptable.
Never, ever, use a global option for demuxer selection. Instead the
specefic demuxer must be forced with the -demuxer or -audio-demuxer
variables (sorry forgot there name) as it's currently done with the
raw demuxers.

	Albeu
-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.