[MPlayer-dev-eng] [PATCH] nvidia_vid update

[Dmitry Baryshkov]

Hello,
On Tue, Jan 06, 2004 at 06:13:32PM +0100, Sascha Sommer wrote:
[skipped]
> >> >+ while (bps == 0)
> >> >+ {
> >> >+  if (info->chip.arch != NV_ARCH_03)
> >> >+   bps = info->chip.PGRAPH[0x00000670/4];
> >> >+  else
> >> >+   bps = info->chip.PGRAPH[0x00000650/4];
> >> >+//  if (bps == 0) fprintf(stderr, "bps returned 0: %d\n");
> >> >+ }
> >> >      x = info->wx - (pan % bps) * 8 / info->depth;
> >> >      y = info->wy - (pan / bps);
> >> >+    }
> >> >+
> >>
> >> I'm currently unable to test it, but afair this register is also 0 in
> >> textmode.
> >
> >Yes, but in text mode info->depth == 0, so the whole block is skipped.
> 
> Please leave this code as it is now unlike you can give me a reason why your
> changes are needed.

Do you agree with this change?
Or are you still waiting for precise numbers from info->chip.PGRAPH[0x00000670/4];?
If you are against infinite loop, maybe it's better to save previous
bps into info struct, and if info->chip.PGRAPH[0x00000670/4] returns 0,
reuse old value?

-- 
With best wishes
Dmitry Baryshkov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20040110/f7d3e90c/attachment.pgp>