[MPlayer-dev-eng] Re: [PATCH] Seek in http-streams

[Valentine Zaretsky]

eviv bulgroz wrote:

>--- Valentine Zaretsky <valik+mplayerdev at email.dp.ua> wrote:
>  
>
>>Hi!
>>
>>Well... It's even simpler and patching stream_file.c is not needed
>>This patch is against CVS and fixes only bugs caused by my http-seek 
>>patch (this time all of them, I hope), but I think that stream_seek_long 
>>function needs further  rewriting -- at least some parts of it output 
>>info message and return 1 instead of error message and returning 0 when 
>>seek cannot be done.
>>
>>    
>>
>
>No, Valentine, this wrong, 
>
Have you tried the patch?

>s->seek points to seek_forward and seek_forward has a bug, it should be
>fixed or not be used. Masking the error by changing the return value doesn't help either, since no
>  
>
It isn't masking the error. stream_seek_long should return 1 if seek was 
successful, so it's wrong to return 1 when it failed.

-- 
Best regards, Valentine