[MPlayer-dev-eng] [PATCH] vo_x11_fullscreen check width and height

Attila Kinali attila at kinali.ch
Tue Feb 24 19:18:57 CET 2004


On Mon, 23 Feb 2004 22:38:57 +0100
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> > I dont like this patch. The window size should never become so small.
> I have to admit I don't like it too much either. But I even more dislike 
> a SIGABORT...(there is also a line saying something like Xerror: 
> BadValue, but as X function aren't synched (or can that be changed) in 
> MPlayer, this doesn't help finding the error)
> Sorry, maybe I wasn't completely clear: The window never becomes so 
> small, vo_gl2 simply doesn't use the function correctly (when staring 
> with -fs it sets the window size to full by itself, so when pressing 
> 'f', vo_old_width and vo_old_height are still 0).
> This is mostly supposed to make it easier to see where that SIGABORT 
> comes from ;-)

I just commited a patch that sets the minimal window size to 4 pixels.
Could you check whether this solves your problem ?

I'll commit another patch on the aspect code too, as vo_x11_size_hint's
way is broken (as soon as i find out how to do it the right way).

			Attila Kinali

-- 
egp ist vergleichbar mit einem ikea bausatz fuer flugzeugtraeger
			-- reeler in +kaosu




More information about the MPlayer-dev-eng mailing list